Skip to content

Remove 2018 deprecated runtime contenttype extension point#1644

Merged
vogella merged 1 commit into
eclipse-platform:masterfrom
vogella:delete-deprecated-extension-point
Jun 9, 2026
Merged

Remove 2018 deprecated runtime contenttype extension point#1644
vogella merged 1 commit into
eclipse-platform:masterfrom
vogella:delete-deprecated-extension-point

Conversation

@vogella

@vogella vogella commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

Planned for 4.41

In 2018 we marked this extension point for deletion, lets remove it for 2025-03.

@HannesWell

Copy link
Copy Markdown
Member

In 2018 we marked this extension point for deletion, lets remove it for 2025-03.

Have you checked if the extension-point is used anywhere in the SDK? I remember that quite a number of extensions for deprecated points exit.

@eclipse-platform-bot

eclipse-platform-bot commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

runtime/features/org.eclipse.core.runtime.feature/feature.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 767711d38d5508be524f0551f98f34e8f67090d9 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sat, 30 May 2026 08:34:11 +0000
Subject: [PATCH] Version bump(s) for 4.41 stream


diff --git a/runtime/features/org.eclipse.core.runtime.feature/feature.xml b/runtime/features/org.eclipse.core.runtime.feature/feature.xml
index 7eddcc12b7..bd0e035c4e 100644
--- a/runtime/features/org.eclipse.core.runtime.feature/feature.xml
+++ b/runtime/features/org.eclipse.core.runtime.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.core.runtime.feature"
       label="%featureName"
-      version="1.4.1200.qualifier"
+      version="1.4.1300.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@vogella

vogella commented Nov 27, 2024

Copy link
Copy Markdown
Contributor Author

Awesome @HannesWell that works. Thank you for the tip

@vogella

vogella commented Nov 27, 2024

Copy link
Copy Markdown
Contributor Author

Have you checked if the extension-point is used anywhere in the SDK? I remember that quite a number of extensions for deprecated points exit.

Will do.

@github-actions

github-actions Bot commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   55m 25s ⏱️ +32s
 4 671 tests ±0   4 649 ✅ ±0   22 💤 ±0  0 ❌ ±0 
11 907 runs  ±0  11 754 ✅ ±0  153 💤 ±0  0 ❌ ±0 

Results for commit 17ff934. ± Comparison against base commit 1223f47.

♻️ This comment has been updated with latest results.

@vogella

vogella commented Apr 26, 2026

Copy link
Copy Markdown
Contributor Author

@vogella

vogella commented Apr 26, 2026

Copy link
Copy Markdown
Contributor Author

@vogella

vogella commented Apr 26, 2026

Copy link
Copy Markdown
Contributor Author

#2633

@merks

merks commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

Removals are best done for M1 and not M3

vogella added a commit to eclipse-platform/eclipse.platform.ui that referenced this pull request Apr 26, 2026
The org.eclipse.core.runtime.contentTypes extension point is being
removed in eclipse-platform/eclipse.platform#1644. Update the two
remaining test fixtures (regression test for bug 107121 in
OpenNavigatorFolderTest, and ObjectContributionTest) to contribute to
org.eclipse.core.contenttype.contentTypes instead.
vogella added a commit to eclipse-platform/eclipse.platform.ui that referenced this pull request Apr 26, 2026
The org.eclipse.core.runtime.contentTypes extension point was removed
in eclipse-platform/eclipse.platform#1644. Update schema documentation
to reference the non-deprecated org.eclipse.core.contenttype.contentTypes
extension point instead.
@vogella vogella force-pushed the delete-deprecated-extension-point branch from 4991a2f to 9dc9b77 Compare May 18, 2026 07:04
@vogella vogella force-pushed the delete-deprecated-extension-point branch 2 times, most recently from 0ed4a22 to c12b524 Compare June 1, 2026 15:59
@merks

merks commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

I assume we don’t need two version increment commits.

@vogella vogella force-pushed the delete-deprecated-extension-point branch from c12b524 to 825334b Compare June 1, 2026 16:43
@vogella

vogella commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Failing test requires that I remove ISV doc references to the soon deleted org.eclipse.core.runtime.contentTypes extension point.

The bundle actually lives in the eclipse.platform.releng.aggregator repo, not eclipse.platform.ui

@vogella

vogella commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Follow-up after this is merged: org.eclipse.core.contenttype ContentTypeBuilder.getConfigurationElements() explicitly reads both points (lines 243–245 fetch the old org.eclipse.core.runtime.contentTypes). Once the point declaration is gone, registry.getExtensionPoint(...) returns null there, so that branch becomes dead code.

@vogella vogella force-pushed the delete-deprecated-extension-point branch from 825334b to ce67dff Compare June 2, 2026 07:19
In 2018 we marked this extension point for deletion, lets remove it.
@vogella vogella force-pushed the delete-deprecated-extension-point branch from ce67dff to 17ff934 Compare June 8, 2026 09:24
@vogella

vogella commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Running my last (grep based) checks on the aggregator now... If that does not find anything I plan to merge, this is loooong in the pipeline.

@vogella

vogella commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

One place present which can be removed after this is gone, will be done via a separate PR.

// "old" extension point
IExtensionPoint oldPoint = registry.getExtensionPoint(IContentConstants.RUNTIME_NAME, PT_CONTENTTYPES);
if (oldPoint != null) {
    oldConfigElements = oldPoint.getConfigurationElements();
}

@vogella vogella merged commit abad270 into eclipse-platform:master Jun 9, 2026
18 checks passed
@vogella vogella deleted the delete-deprecated-extension-point branch June 9, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants